[PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.

Michael Matz matz@suse.de
Mon Nov 5 18:37:00 GMT 2018


Hi,

On Fri, 2 Nov 2018, Martin Liška wrote:

> V2 of the patch.
> 
> Thoughts?

Whereever the new function belongs it certainly isn't system.h.  Also the 
definition in a header seems excessive.  Sure, it enables inlining of it, 
but that seems premature optimization.  It contains a loop, and inlining 
anything with loops that aren't very likely to loop just once or never 
just blows code for no gain.  Also as the function is leaf there won't be 
any second-order effect from inlining.


Ciao,
Michael.


More information about the Gcc-patches mailing list