[PATCH][RFC] Radically simplify emission of balanced tree for switch statements.
Martin Liška
mliska@suse.cz
Fri May 18 14:19:00 GMT 2018
On 05/18/2018 03:55 PM, Rainer Orth wrote:
> Hi Martin,
>
>> So the patch looks fine, only very very slightly binary is produced. I'm
>> going to install the patch so that
>> I can carry on more complex patches based on this one.
>
> it seems you didn't properly test the testsuite part: I see
>
> +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower "Removing basic block"
> +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower "loop depth 1, count 33333"
> +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump-not switchlower "Invalid sum"
> +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump-not switchlower "loop depth 1, count 33332"
>
> everywhere. The log has
>
> gcc.dg/tree-prof/update-loopch.c: dump file does not exist
>
> Obviously you forgot the adapt the dg-final* files for the dumpfile
> name. If I do, three of the failures go away, but
>
> FAIL: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower1 "Removing basic block"
>
> remains (on 32 and 64-bit Linux/x86_64).
>
> Please fix.
>
> Rainer
>
Thanks for opened eyes, following patch will fix that.
It's quite obvious, I'll install it right after tests will finish.
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-redundand-pass-pass_lower_switch.patch
Type: text/x-patch
Size: 914 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180518/844ccb35/attachment.bin>
More information about the Gcc-patches
mailing list