[PATCH, rs6000] Improve Documentation of Built-In Functions Part 1

Segher Boessenkool segher@kernel.crashing.org
Wed May 2 13:43:00 GMT 2018


Hi Kelvin,

On Tue, Apr 24, 2018 at 09:12:52AM -0500, Kelvin Nilsen wrote:
>     * doc/extend.texi: Tidy documentation of PowerPC built-in functions.

You should note the sections you renamed:
	(PowerPC Built-in Functions): Rename to ...
	(Low-Level PowerPC Built-in Functions): ... this.
(but see below).

> --- gcc/doc/extend.texi    (revision 259504)
> +++ gcc/doc/extend.texi    (working copy)
> @@ -15524,12 +15524,17 @@ implementing assertions.
> -@node PowerPC Built-in Functions
> -@subsection PowerPC Built-in Functions
> +@node Low-Level PowerPC Built-in Functions
> +@subsection Low-Level PowerPC Built-in Functions

If you change the name of a node you need to also change it wherever
it is referred to.  In this case, importantly the menu of per-target
built-in function documentation.  We probably should keep this
subsection's name, maybe do a subsubsection or such?

There is nothing particularly low-level about these builtins; maybe
call it "basic builtins" or similar?

Or we probably should start the "PowerPC Built-in Functions" node
with a menu of its subsubsections?  Like what FR-V has.

Sorry for the late review.


Segher



More information about the Gcc-patches mailing list