libgo patch committed: add missing entry to noinst_DATA
Ian Lance Taylor
iant@golang.org
Fri Mar 16 19:22:00 GMT 2018
This libgo patch adds runtime/pprof/internal/profile.gox to
noinst_DATA. That package is only used by tests, so it needs to be in
noinst_DATA to ensure that it is built when tests are run.
It also adds noinst_DATA to CHECK_DEPS; it's not needed in practice
since `make` will build noinst_DATA, but it's logically required and
will make a difference if any of the noinst_DATA sources change
between `make` and `make check`.
As an aside,
Tony Reix figured out why omitting packages from noinst_DATA didn't
seem to matter: because if gccgo can't find foo.gox, it will fall back
to reading the export data in foo.o, and foo.o will exist because
these packages go into libgo.a.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed
to mainline.
Ian
-------------- next part --------------
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE (revision 258565)
+++ gcc/go/gofrontend/MERGE (working copy)
@@ -1,4 +1,4 @@
-e4464efc767b8dee4f4c18ffaf6c891f7b9deee7
+e9c0e4d8fd3d951a367bb6a50e5cb546e01b81a8
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
Index: libgo/Makefile.am
===================================================================
--- libgo/Makefile.am (revision 258392)
+++ libgo/Makefile.am (working copy)
@@ -399,7 +399,8 @@ noinst_DATA = \
internal/testenv.gox \
internal/trace.gox \
net/internal/socktest.gox \
- os/signal/internal/pty.gox
+ os/signal/internal/pty.gox \
+ runtime/pprof/internal/profile.gox
if LIBGO_IS_RTEMS
rtems_task_variable_add_file = runtime/rtems-task-variable-add.c
@@ -1094,6 +1095,7 @@ CHECK_DEPS = \
$(toolexeclibgotext_DATA) \
$(toolexeclibgotexttemplate_DATA) \
$(toolexeclibgounicode_DATA) \
+ $(noinst_DATA) \
$(noinst_LIBRARIES)
if GOC_IS_LLGO
More information about the Gcc-patches
mailing list