PING^2: [PATCH] Use dlsym to check if libdl is needed for plugin

[H.J. Lu]

On Wed, Feb 21, 2018 at 3:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Oct 18, 2017 at 5:25 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> config/plugins.m4 has
>>
>>  if test "$plugins" = "yes"; then
>>     AC_SEARCH_LIBS([dlopen], [dl])
>>   fi
>>
>> Plugin uses dlsym, but libasan.so only intercepts dlopen, not dlsym:
>>
>> [hjl@gnu-tools-1 binutils-text]$ nm -D /lib64/libasan.so.4| grep " dl"
>> 0000000000038580 W dlclose
>>                  U dl_iterate_phdr
>> 000000000004dc50 W dlopen
>>                  U dlsym
>>                  U dlvsym
>> [hjl@gnu-tools-1 binutils-text]$
>>
>> Testing dlopen for libdl leads to false negative when -fsanitize=address
>> is used.  It results in link failure:
>>
>> ../bfd/.libs/libbfd.a(plugin.o): undefined reference to symbol 'dlsym@@GLIBC_2.16'
>>
>> dlsym should be used to check if libdl is needed for plugin.
>>
>> OK for master?
>>
>> H.J.
>> ---
>> bfd/
>>
>>         PR gas/22318
>>         * configure: Regenerated.
>>
>> binutils/
>>
>>         PR gas/22318
>>         * configure: Regenerated.
>>
>> config/
>>
>>         * plugins.m4 (AC_PLUGINS): Use dlsym to check if libdl is needed.
>>
>> gas/
>>
>>         PR gas/22318
>>         * configure: Regenerated.
>>
>> gprof/
>>
>>         PR gas/22318
>>         * configure: Regenerated.
>>
>> ld/
>>
>>         PR gas/22318
>>         * configure: Regenerated.

PING.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-dlsym-to-check-if-libdl-is-needed-for-plugin.patch
Type: text/x-patch
Size: 1280 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180314/66c0c5a4/attachment.bin>