[PATCH, GCC/testsuite] Fix FAIL display for some scan-*-times directives

Thomas Preudhomme thomas.preudhomme@foss.arm.com
Tue Mar 13 17:34:00 GMT 2018


Hi,

scan-assembler-times and scan-tree-dump-times dejagnu directives show a
different output in the summary files depending on whether they PASS or
FAIL. This means that dg-cmp-results would not show a regression because
it would not see a connection between the two output.

The difference comes from the FAIL showing the number of actual times
the pattern was match, presumably to help debugging. This patch moves
the info regarding the actual number of times the pattern match in a
separate verbose message. This keeps the message unchanged but let
developers have the required debug message with -v.

ChangeLog entry is as follows:

*** gcc/testsuite/ChangeLog ***

2018-03-13  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* lib/scanasm.exp (scan-assembler-times): Move FAIL debug info into a
	separate verbose message.
	* lib/scandump.exp (scan-dump-times): Likewise.

Testing: Made a modified version of gcc.dg/nand.c and
gcc.dg/torture/pr61772.c to FAIL their scan-assembler-times and
scan-tree-dump-times respective directives. Without the patch
dg-cmp-results does not flag any regression but does with the patch.

Is this ok for stage 4?

Best regards,

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_scan_times_fail_message.patch
Type: text/x-patch
Size: 1162 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180313/5533c6e6/attachment.bin>


More information about the Gcc-patches mailing list