[PATCH] fix ICE in generic_overlap (PR 84526)

[Martin Sebor]

Ping: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg01441.html

Jeff, I know this is in your queue.  I ping it because a bug
with the same root cause was reported in RHBZ #1552639.

On 02/26/2018 11:13 AM, Martin Sebor wrote:
> On 02/26/2018 10:39 AM, Jakub Jelinek wrote:
>> On Mon, Feb 26, 2018 at 10:32:27AM -0700, Martin Sebor wrote:
>>> That attached revision updates the pass to directly convert
>>> the poly64_int into offset_int using the API suggested by
>>> Richard (thanks again).  As discussed below, I've made no
>>> other changes.
>>>
>>> Jakub, if you still have concerns that the false positive
>>> suppression logic isn't sufficiently effective please post
>>> a test case (or open a new bug).  I will look into it when
>>> I get a chance.
>>
>> Yes, I still have major concerns, I explained what I'd like to see
>> (differentiate clearly between what base is, either by adding a flag or
>> having separate base and base_addr, then in the users you can easily find
>> out what is what and can decide based on that).
>
> I'm open to making these improvements but without a test case
> or a way to validate them I'm not comfortable making intrusive
> changes in this area at this late stage.  As I explained, the
> code cannot be reached under the conditions you described.
> In any event, the improvements you suggest are independent of
> the fix for the ICE.
>
>>> Until then, I'd like to get the ICE fix committed. Please
>>> confirm that the attached patch is good to go in.
>>
>> Due to the above concerns, I don't think the patch is good to go in.
>> If you find somebody else who thinks the patch is ok, I won't fight
>> against
>> it though.
>
> Jeff, when you have a chance, can you please review/approve
> the patch?
>
> https://gcc.gnu.org/ml/gcc-patches/2018-02/msg01441.html
>
> Martin