[PATCH] Fix ICE on invalid inline asm with "X" constraint and non-zero CONST_VECTOR (PR inline-asm/84625)

Uros Bizjak ubizjak@gmail.com
Fri Mar 2 07:53:00 GMT 2018


On Fri, Mar 2, 2018 at 8:47 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Mar 02, 2018 at 08:19:40AM +0100, Uros Bizjak wrote:
>> On Fri, Mar 2, 2018 at 8:16 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> > On Fri, Mar 2, 2018 at 12:10 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> >> Hi!
>> >>
>> >> Assertions are only useful when inline asm is not involved, otherwise users
>> >> can write anything they want.
>>
>> IIRC, we can also handle { -1, -1, ... , -1 } in certain cases, but I
>> don't think it is worth to complicate here.
>
> We can handle that as whole instruction special-casing all ones
> CONST_VECTOR, sure, but as an operand in inline-asm?
>
> Even the { 0, 0, ... , 0 } case is weird, we print it just as 0, dunno
> where exactly it would make sense, but we were doing that in the past
> already.

Probably QImode/HImode vector zero can be represented as DImode
immediate in an integer move insn. Anyway, let's proceed with your
original patch.

Uros.



More information about the Gcc-patches mailing list