[patch] Remap goto_locus on edges during inlining

Richard Biener richard.guenther@gmail.com
Thu Jun 28 09:49:00 GMT 2018


On Tue, Jun 26, 2018 at 10:12 PM Jeff Law <law@redhat.com> wrote:
>
> On 06/26/2018 02:54 AM, Eric Botcazou wrote:
> > Hi,
> >
> > this makes sure the goto_locus present (or not) on edges is properly remapped
> > during inlining.
> >
> > Tested on x86-64/Linux, OK for the mainline?
> >
> >
> > 2018-06-26  Eric Botcazou  <ebotcazou@adacore.com>
> >
> >       * tree-inline.c (remap_location): New function extracted from...
> >       (copy_edges_for_bb): Add ID parameter.  Remap goto_locus.
> >       (copy_phis_for_bb): ...here.  Call remap_location.
> >       (copy_cfg_body): Adjust call to copy_edges_for_bb.
> OK.

Related we're also missing to verify_location () on those in
verify_gimple_in_cfg.  Having stale references to GCed BLOCKs
via locations can be difficult to track down...

So can you add the verification bits as well?

Thanks,
Richard.

> jeff



More information about the Gcc-patches mailing list