[PATCH 1/5] emit-rtl.c: more typesafety

[Jeff Law]

On 06/12/2018 12:54 PM, David Malcolm wrote:
> This patch converts various rtx to rtx_insn * (or rtx_code_label *).
> It also convert the various "_loc" params from int to location_t
> 
> gcc/ChangeLog:
> 	* emit-rtl.c (next_real_insn): Strengthen param from "rtx"
> 	to "rtx_insn *".
> 	(add_insn_after): Likewise for first two params.
> 	(add_insn_before): Likewise.
> 	(remove_insn): Likewise for param.
> 	(emit_pattern_before_noloc): Likewise for second and third params.
> 	(emit_jump_insn_before_noloc): Convert NULL_RTX to NULL.
> 	(emit_call_insn_before_noloc): Likewise.
> 	(emit_debug_insn_before_noloc): Strengthen "before" param from "rtx"
> 	to "rtx_insn *".
> 	(emit_barrier_before): Likewise.
> 	(emit_label_before): Strengthen "label" param from "rtx" to
> 	"rtx_code_label *".  Strengthen "before" param from "rtx" to
> 	"rtx_insn *".
> 	(emit_insn_after_1): Strengthen "after" param from "rtx" to
> 	"rtx_insn *".
> 	(emit_pattern_after_noloc): Likewise.
> 	(emit_insn_after_noloc): Likewise.
> 	(emit_jump_insn_after_noloc): Likewise.
> 	(emit_call_insn_after_noloc): Likewise.
> 	(emit_debug_insn_after_noloc): Likewise.
> 	(emit_barrier_after): Likewise.
> 	(emit_label_after): Likewise for both params.
> 	(emit_pattern_after_setloc): Likewise for "after" param.  Convert
> 	"loc" param from "int" to "location_t".
> 	(emit_insn_after_setloc): Likewise.
> 	(emit_jump_insn_after_setloc): Likewise.
> 	(emit_call_insn_after_setloc): Likewise.
> 	(emit_debug_insn_after_setloc): Likewise.
> 	(emit_pattern_before_setloc): Likewise for "before" param.  Convert
> 	"loc" param from "int" to "location_t".
> 	(emit_pattern_before): Convert NULL_RTX to NULL.
> 	(emit_insn_before_setloc): Convert "loc" param from "int" to
> 	"location_t".
> 	(emit_jump_insn_before_setloc): Likewise.
> 	(emit_call_insn_before_setloc): Likewise.
> 	(emit_debug_insn_before_setloc): Strengthen "before" param from rtx to
> 	rtx_insn *.  Convert "loc" param from "int" to "location_t".
> 	* rtl.h (emit_insn_before_setloc, emit_jump_insn_before_setloc,
> 	emit_call_insn_before_setloc, emit_debug_insn_before_setloc):
> 	Convert 3rd param from "int" to "location_t".
> 	(emit_barrier_before, emit_barrier_after, next_real_insn):
> 	Strengthen param from rtx to rtx_insn *.
> 	(emit_label_before): Strengthen 1st param from "rtx" to
> 	"rtx_code_label *".  Strengthen 2nd param from "rtx" to
> 	"rtx_insn *".
> 	(emit_insn_after_noloc, emit_jump_insn_after_noloc,
> 	emit_call_insn_after_noloc, emit_debug_insn_after_noloc):
> 	Strengthen 2nd param from "rtx" to "rtx_insn *".
> 	(emit_insn_after_setloc, emit_jump_insn_after_setloc)
> 	emit_call_insn_after_setloc, emit_debug_insn_after_setloc):
> 	Likewise. Convert 3rd param from "int" to "location_t".
> 	(emit_label_after): Strengthen 1st param from "rtx" to
> 	"rtx_code_label *".
> 	(next_real_insn, remove_insn): Strengthen param from "rtx" to
> 	"rtx_insn *".
> 	(add_insn_before, add_insn_after): Strengthen 1st and 2nd params
> 	from "rtx" to "rtx_insn *".
OK.  I think that covers the entire set.

I can't immediately recall if the as-a and safe-as-a are compile or
runtime checks.  Obviously your testing ought to be sufficient for the
former.  Mine will help with the latter since it'll build arc, bfin and
c6x elf targets through newlib.  For sh it'll build a mixture of -elf
things through newlib and it'll bootstrap sh4.

jeff