[PATCH][arm] Make gcc.target/arm/copysign_softfloat_1.c more robust

Kyrill Tkachov kyrylo.tkachov@foss.arm.com
Tue Jan 23 15:42:00 GMT 2018


Hi Christophe,

On 23/01/18 13:09, Christophe Lyon wrote:
> Hi Kyrill,
>
> On 22 January 2018 at 11:48, Kyrill  Tkachov
> <kyrylo.tkachov@foss.arm.com> wrote:
>> Hi all,
>>
>> This test has needlessly restrictive requirements. It tries to force a
>> soft-float target and tries to run.
>> This makes it unsupportable for any non-soft-float variant.
>> In fact, the test can be a run-time test for any target, and only the
>> scan-assembler tests are specific to
>> -mfloat-abi=soft. So this patch makes the test always runnable and makes the
>> scan-assembler checks predicable
>> on the the new arm_sotftfloat effective target check.
>>
> Unfortunately, the test now fails on armeb-linux-gnueabihf (it used to
> be unsupported).
> my logs only show:
> qemu: uncaught target signal 11 (Segmentation fault) - core dumped

:( it runs fine for me on a armeb-none-eabi --with-float=hard target with a Foundation Model.
Unfortunately I don't have access to an armeb-non-linux-gnueabihf setup.
Could you provide more detailed configuration options so that I can try to reproduce the
exact -march -m[arm,thumb], -mfpu setup?

Thanks,
Kyrill

> on arm-linux-gnueabihf, it's OK (the test was unsupported, but now passes)
>
> Christophe
>
>> Committing to trunk.
>> Thanks,
>> Kyrill
>>
>> 2018-01-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>      * doc/sourcebuild.texi (arm_softfloat): Document.
>>
>> 2018-01-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>      * lib/target-supports.exp (check_effective_target_arm_softfloat):
>>      New procedure.
>>      * gcc.target/arm/copysign_softfloat_1.c: Allow running everywhere.
>>      Adjust scan-assembler checks for soft-float.



More information about the Gcc-patches mailing list