Protect second call to extract_range_from_multiplicative_op_1

Jeff Law law@redhat.com
Thu Jan 4 18:34:00 GMT 2018


On 01/04/2018 03:11 AM, Richard Sandiford wrote:
> Following on from:
> 
>         * tree-vrp.c (extract_range_from_multiplicative_op_1): Assert
>         for VR_RANGE only; don't allow VR_ANTI_RANGE.
>         (extract_range_from_binary_expr_1): Don't call
>         extract_range_from_multiplicative_op_1 if !range_int_cst_p.
> 
> there was a later call to extract_range_from_multiplicative_op_1 too,
> that used a negative test for a symbolic (!is_gimple_min_invariant)
> range rather than a positive test for an integer range.
> 
> Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu.
> Also tested by comparing the before and after assembly output for at
> least one target per CPU directory.  OK to install?
> 
> Richard
> 
> 
> 2018-01-04  Richard Sandiford  <richard.sandiford@linaro.org>
> 
> gcc/
> 	* tree-vrp.c (extract_range_from_binary_expr_1): Check
> 	range_int_cst_p rather than !symbolic_range_p before calling
> 	extract_range_from_multiplicative_op_1.
OK.
jeff



More information about the Gcc-patches mailing list