[PATCH, rs6000] Fix PR84534: several powerpc test cases fail starting with r257915

Segher Boessenkool segher@kernel.crashing.org
Wed Feb 28 22:36:00 GMT 2018


Hi!

On Wed, Feb 28, 2018 at 09:39:14AM -0600, Peter Bergner wrote:
> This patch fixes PR84534 by XFAILing one test because we are deprecating
> -maltivec=be when run on LE.  The other tests are fixed by not counting
> xxlor insns.  We cannot rely on stable counts of xxlor insns, because we
> generate them not only when using __builtin_vec_or(), but also whenever
> we need to copy one vsx reg to another...which can vary depending on
> previous optimizations, moon phases, etc.  Therefore, we just make sure
> we generate at least one.  I'll note I did try adding -dp and seeing
> which patterns generated the xxlors, but there wasn't a clear match
> between the xxlor's generated because of the __builtin_vec_or and the
> reg copies.

> gcc/testsuite/
> 	PR target/84534
> 	* gcc.target/powerpc/vec-setup-be-long.c: xfail.

"Add xfail for powerpc64le" or similar?

> 	* gcc.target/powerpc/vsx-vector-6-le.c: Do not count xxlor's.
> 	* gcc.target/powerpc/vsx-vector-6-le.p9.c: Likewise.

Please add a comment to the testcase why there is no count here.

Okay for trunk with that.  Thanks!


Segher



More information about the Gcc-patches mailing list