[PATCH] libgcc: xtensa: fix build with -mtext-section-literals

Max Filippov jcmvbkbc@gmail.com
Wed Feb 7 22:10:00 GMT 2018


On Thu, Feb 1, 2018 at 9:12 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Wed, Jan 31, 2018 at 11:17 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> On Wed, Jan 31, 2018 at 11:11 AM, augustine.sterling@gmail.com <augustine.sterling@gmail.com> wrote:
>>> On Tue, Jan 30, 2018 at 8:02 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>>>>
>>>> libgcc/
>>>> 2018-01-31  Max Filippov  <jcmvbkbc@gmail.com>
>>>>
>>>>         * config/xtensa/ieee754-df.S (__adddf3_aux): Add
>>>>         .literal_position directive.
>>>>         * config/xtensa/ieee754-sf.S (__addsf3_aux): Likewise.
>>>
>>> This is fine, but when did it stop working, and why isn't there a test
>>> that would catch it?
>>
>> I broke it with the recent softfloat NaN fix. Haven't noticed that because
>> I usually build without any flags or with -mauto-litpools.
>> Let me add the test, thanks for the suggestion.
>
> I've taken a look at gcc testsuites and I don't see how to add a test that would
> check that libgcc builds with different compiler options. Any suggestions?

If there are no suggestions I will check in the fix as is and will add building
with -mtext-section-literals to my testing scripts.

-- 
Thanks.
-- Max



More information about the Gcc-patches mailing list