Fix hashtable node deallocation
François Dumont
frs.dumont@gmail.com
Sun Dec 23 18:49:00 GMT 2018
On 12/21/18 9:29 PM, Jonathan Wakely wrote:
> On 16/12/18 14:16 +0100, François Dumont wrote:
>> Gentle reminder, we still have this issue pending.
>>
>> Â Â Â * include/bits/hashtable_policy.h
>> (_Hashtable_alloc<>::_M_deallocate_node_ptr(__node_type*)): New.
>> (_Hashtable_alloc<>::_M_deallocate_node(__node_type*)): Use latter.
>> (_ReuseOrAllocNode<>::operator<_Arg>()(_Arg&&)): Likewise.
>
> Please add more detail to the commit message explaining the problem.
> Either as a paragraph of text in the commit message before the
> changelog (e.g. see https://gcc.gnu.org/r267236 or
> https://gcc.gnu.org/r267276 for commits with additional text in the
> commit message), or in the changelog itself, e.g.
>
> (_ReuseOrAllocNode<>::operator<_Arg>()(_Arg&&)): Likewise, so
> Â Â Â Â Â Â that the argument to __node_alloc_traits::deallocate is the
> Â Â Â Â Â Â correct pointer type.
>
>> Â Â Â * libstdc++-v3/testsuite/util/testsuite_allocator.h
>> Â Â Â (CustomPointerAlloc<>::allocate(size_t, pointer)): Replace by...
>> Â Â Â (CustomPointerAlloc<>::allocate(size_t, const_void_pointer)):
>> ...this.
>
> This should have been a separate commit really.
>
> OK for trunk with a better commit message that explains what the
> change does.
>
>
Committed in 2 different commits.
I hope you will appreciate my additional message, I didn't notice yours
before writting mine.
François
More information about the Gcc-patches
mailing list