[PATCH] Don't run ident tests on powerpc-darwin

Jeff Law law@redhat.com
Sun Dec 23 18:17:00 GMT 2018


On 12/23/18 4:16 AM, Iain Sandoe wrote:
> Hi
> 
> The c-c++-common tests fail (or XPASS depending on which) on Darwin
> because it doesn't currently emit .ident marker. 
> 
> For powerpc darwin (and, I think, AIX - hence copying David), there’s no
> .ident support in the assembler, and we need to skip the tests.
> 
> In this case, I suggest that it’s not worth having a target-supports entry.
> This is because what a target chooses to emit for -fident is controlled by
> a target hook and therefore there’s no guarantee that a target-supports
> that triggers off “ .ident” in the asm would be generically useful.
> 
> OTOH, if the testsuite maintainers prefer a support .. it can be done ;-)
> 
> OK for trunk?
> Iain
> 
> gcc/testsuite/
> 
> 	* c-c++-common/ident-0a.c: Skip for powerpc-darwin.
> 	* c-c++-common/ident-0b.c: Likewise.
> 	* c-c++-common/ident-1a.c: Likewise.
> 	* c-c++-common/ident-1b.c: Likewise.
> 	* c-c++-common/ident-2a.c: Likewise.
> 	* c-c++-common/ident-2b.c: Likewise.
OK
jeff



More information about the Gcc-patches mailing list