[PATCH] attribute copy, leaf, weakref and -Wmisisng-attributes (PR 88546)

Martin Sebor msebor@gmail.com
Sat Dec 22 02:13:00 GMT 2018


On 12/21/18 5:16 PM, Jakub Jelinek wrote:
> On Fri, Dec 21, 2018 at 04:50:47PM -0700, Martin Sebor wrote:
>> The first revision of the patch was missing a test and didn't
>> completely or completely correctly handle attribute noreturn.
>> Attached is an update with the test included and the omission
>> and bug fixed.
>>
>> I think it makes sense to consider the patch independently of
>> the question whether weakrefs should be extern.  That change can
> 
> Weakrefs shouldn't be extern, that is what we were using initially and
> changed to static.  At this point we can't change that again IMNSHO.

Sorry, I mixed things up.  What I meant is "independently of
the question whether leaf should be accepted on extern declarations."

Martin



More information about the Gcc-patches mailing list