[patch,openacc] Fix PR71959: lto dump of callee counts
Julian Brown
julian@codesourcery.com
Fri Dec 21 13:29:00 GMT 2018
On Fri, 21 Dec 2018 02:56:36 +0000
Julian Brown <julian@codesourcery.com> wrote:
> On Tue, 25 Sep 2018 14:59:18 +0200
> Martin Jambor <mjambor@suse.cz> wrote:
>
> > Hi,
> >
> > I have noticed a few things...
> >
> > On Thu, Sep 20 2018, Cesar Philippidis wrote:
> > > This is another old gomp4 patch that demotes an ICE in PR71959 to
> > > a linker warning. One problem here is that it is not clear if
> > > OpenACC allows individual member functions in C++ classes to be
> > > marked as acc routines. There's another issue accessing member
> > > data inside offloaded regions. We'll add some support for member
> > > data OpenACC 2.6, but some of the OpenACC C++ semantics are still
> > > unclear.
> > >
> > > Is this OK for trunk? I bootstrapped and regtested it for x86_64
> > > Linux with nvptx offloading.
> > [...]
>
> The testcase associated with this bug appears to be fixed by the
> following patch:
>
> https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01167.html
>
> So, it's unclear if there's anything left to do here, and this patch
> can probably be withdrawn.
...or actually, maybe we should keep the new testcase in case of future
regressions. This patch contains just that.
OK to apply?
Thanks,
Julian
ChangeLog
2018-xx-yy Nathan Sidwell <nathan@acm.org>
PR lto/71959
libgomp/
* testsuite/libgomp.oacc-c++/pr71959-a.C: New.
* testsuite/libgomp.oacc-c++/pr71959.C: New.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr71959-test-only.diff
Type: text/x-patch
Size: 1809 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20181221/9a13b3eb/attachment.bin>
More information about the Gcc-patches
mailing list