[PATCH][GCC][AARCH64] Use stdint integers in vect_su_add_sub.c

Kyrill Tkachov kyrylo.tkachov@foss.arm.com
Wed Aug 29 08:29:00 GMT 2018


Hi all,

On 28/08/18 23:15, James Greenhalgh wrote:
> On Fri, Aug 03, 2018 at 11:28:08AM -0500, Matthew Malcomson wrote:
>> On 02/08/18 20:18, James Greenhalgh wrote:
>>> On Tue, Jul 31, 2018 at 04:53:19AM -0500, Matthew Malcomson wrote:
>>>> Fixing the ilp32 issue that Christophe found.
>>>>
>>>> The existing testcase uses `long` to represent a 64 bit integer.
>>>> This breaks when compiled using the `-mabi=ilp32` flag.
>>>> We switch the use of int/long for int32_t/int64_t to avoid this problem
>>>> and show the requirement of a widening operation more clearly.
>>> Normally we try to avoid pulling more headers than we need in the testsuite.
>>>
>>> Have you seen this construct:
>>>
>>>     typedef unsigned __attribute__((mode(DI))) uint64_t;
>>>
>>> It can be a good way to ensure you have the right type for the patterns you
>>> are adding.
>>>
>>> Thanks,
>>> James
>> Thanks! No I hadn't seen that construct before.
>> Have attached a patch using that construct.
> OK.

I've committed this on behalf of Matthew as r263946 with an updated ChangeLog entry

2018-08-29  Matthew Malcomson  <matthew.malcomson@arm.com>

     * gcc.target/aarch64/simd/vect_su_add_sub.c: Use 32 and 64-bit types
     where appropriate.

Matthew, if you'd like Write-after-Approval access to the repo to commit your own patches in the future please fill out the form
at https://sourceware.org/cgi-bin/pdw/ps_form.cgi with an SSH public key and put my email from the MAINTAINERS file as the approver.

Thanks,
Kyrill

> Thanks,
> James
>



More information about the Gcc-patches mailing list