[PATCH][RFC] Add gimple-cfg.h.

Martin Liška mliska@suse.cz
Mon Aug 27 08:43:00 GMT 2018


On 08/27/2018 09:56 AM, Richard Biener wrote:
> On Mon, Aug 27, 2018 at 9:13 AM Martin Liška <mliska@suse.cz> wrote:
>>
>> Hi.
>>
>> There's updated version with notes that were discussed with Richi
>> on IRC. As pointed out label_to_block can potentially lead to
>> quadratic complexity, but it's not ambition of the patch to resolve
>> that.
> 
> Please don't
> 
> @@ -3239,7 +3239,7 @@ expand_asm_stmt (gasm *stmt)
>              may insert further instructions into the same basic block after
>              asm goto and if we don't do this, insertion of instructions on
>              the fallthru edge might misbehave.  See PR58670.  */
> -         if (fallthru_bb && label_to_block_fn (cfun, label) == fallthru_bb)
> +         if (fallthru_bb && label_to_block (label) == fallthru_bb)
>             {
>               if (fallthru_label == NULL_RTX)
>                 fallthru_label = gen_label_rtx ();
> 
> rather the label_to_block function should go away.  OK with removing any
> such instances in the patch.
> 
> Richard.
> 
>> Martin

Ok, I'm sending one more version where I completely removed label_to_block_fn.
Richi, out of the modified function, which would be subject for introduction
of a new argument (struct *function)?

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-new-gswitch-related-functions-into-tree-cfg.c.patch
Type: text/x-patch
Size: 33731 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180827/a6cebb33/attachment.bin>


More information about the Gcc-patches mailing list