[libiberty patch] PEX-unix forking

Nathan Sidwell nathan@acm.org
Tue Aug 21 00:00:00 GMT 2018


On 08/20/2018 05:36 PM, Ian Lance Taylor wrote:

> As a matter of style I don't personally like the pattern in which a
> condition has both tests and actions.  It's too easy to miss the
> action.  I would prefer to see this more like the original code:
> 
>      if (!bad_fn && in != STDIN_FILE_NO)
>        {
>          if (close(in) < 0)
>              bad_fn = "close";
>        }
> 
> This is OK with those changes.

Fair enough, committing the attached.  I've elided the unnecessary braces, as 
there are no trailing elses in this case.

nathan

-- 
Nathan Sidwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pex-1-b.diff
Type: text/x-patch
Size: 6710 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180821/029fdd03/attachment.bin>


More information about the Gcc-patches mailing list