[PATCH, Darwin] Do not run dsymutil automatically, when -save-temps is on the command line.

[Mike Stump]

On Aug 18, 2018, at 1:17 PM, Iain Sandoe <iain@sandoe.co.uk> wrote:
> 
> The point of running dsymutil automatically from collect2 is that it
> (collect2, lto-wrapper, etc) might be generating or using compiler
> temporary files that will be deleted at the end of the link process.
> 
> dsymutil requires that it can see the objects actually used in the link
> since it actually picks up the debug info from those, rather than the
> linked exe.
> 
> When “-save-temps” is given, the objects should be preserved (if they
> are not, then that’s a bug) and therefore we don’t need to run dsymutil
> automatically.
> 
> The debug experience can be better with GDB + the original objects for
> some permutations of dsymutil / GDB.
> 
> Opinions? 

So, I think of -save-temps as a debugging thing, and as such, kinda don't want it to change anything.  I don't think people use this in production to manage their builds.

I think it's an over optimization.