[PATCH] Come up with TARGET_GET_VALID_OPTION_VALUES option hook (PR driver/83193).

Ramana Radhakrishnan ramana.gcc@googlemail.com
Mon Aug 13 13:35:00 GMT 2018


On Mon, Aug 13, 2018 at 2:00 PM, Martin Liška <mliska@suse.cz> wrote:
> On 08/13/2018 02:54 PM, Ramana Radhakrishnan wrote:
>> On Mon, Aug 13, 2018 at 1:49 PM, Martin Liška <mliska@suse.cz> wrote:
>>> PING^1
>>>
>>> On 07/24/2018 02:05 PM, Martin Liška wrote:
>>>> Hi.
>>>>
>>>> I'm sending updated version of the patch. It comes up with a new target common hook
>>>> that provide option completion list. It's used both in --help=target and with --completion
>>>> option. I implemented support for -match and -mtune for i386 target.
>>>>
>>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>>
>> Err I don't maintain the x86 backend to review this effectively. In an
>> ideal world you would have split this into 2 patches 1 for the common
>> parts and 1 for x86 and CC'd the relevant x86 maintainers. I'm not
>> clear what you are looking for here from me :-/
>
> Sorry, I was not clear. I would like to hear from ARM's folks that interface
> design is fine for them? I know a global reviewer will have to approve that.

Ok, thanks for the explanation , I'll try and have a look but my
afternoon's looking shafted.

Ramana
>
> Martin
>
>>
>> Ramana
>>>>
>>>> Martin
>>>>
>>>
>



More information about the Gcc-patches mailing list