GCC 8.1 RC1 Bootstrap comparison failure on AIX

Jakub Jelinek jakub@redhat.com
Thu Apr 26 08:35:00 GMT 2018


On Thu, Apr 26, 2018 at 09:56:30AM +0200, Richard Biener wrote:
> --- gcc/cgraph.h        (revision 259668)
> +++ gcc/cgraph.h        (working copy)
> @@ -2222,7 +2222,7 @@ public:
>    void dump (FILE *f);
> 
>    /* Dump symbol table to stderr.  */
> -  inline DEBUG_FUNCTION void debug (void)
> +  DEBUG_FUNCTION void debug (void)
>    {
>      dump (stderr);
>    }
> 
> fix it?

This is a method defined in the class which is inline even without
inline keyword, we'd need instead:

2018-04-26  Richard Biener  <rguenther@suse.de>
	    Jakub Jelinek  <jakub@redhat.com>

	* cgraph.h (symbol_table): Just declare debug method here.
	* symtab.c (symbol_table::debug): Define.

--- gcc/cgraph.h.jj	2018-02-09 06:44:29.992809176 +0100
+++ gcc/cgraph.h	2018-04-26 10:22:41.176748872 +0200
@@ -2222,10 +2222,7 @@ public:
   void dump (FILE *f);
 
   /* Dump symbol table to stderr.  */
-  inline DEBUG_FUNCTION void debug (void)
-  {
-    dump (stderr);
-  }
+  DEBUG_FUNCTION void debug (void);
 
   /* Return true if assembler names NAME1 and NAME2 leads to the same symbol
      name.  */
--- gcc/symtab.c.jj	2018-02-09 06:44:38.389804442 +0100
+++ gcc/symtab.c	2018-04-26 10:25:28.565831384 +0200
@@ -947,6 +947,12 @@ symbol_table::dump (FILE *f)
     node->dump (f);
 }
 
+DEBUG_FUNCTION void
+symbol_table::debug (void)
+{
+  dump (stderr);
+}
+
 /* Return the cgraph node that has ASMNAME for its DECL_ASSEMBLER_NAME.
    Return NULL if there's no such node.  */
 


	Jakub



More information about the Gcc-patches mailing list