Fix PR 85423 (Re: Fix PRs 80463, 83972, 83480)
Alexander Monakov
amonakov@ispras.ru
Mon Apr 23 16:35:00 GMT 2018
On Mon, 23 Apr 2018, Andrey Belevantsev wrote:
> Hello,
>
> So this PR shows that I have incorrectly mirrored the conditional from
> sched-deps.c that creates the dependence from a debug insn on the previous
> insn (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80463#c3 for the
> hunk). Thus we have incorrectly discarded some legitimate debug-debug
> dependencies. The straightforward fix works for all of four PRs, tested on
> x86-64.
>
> I have put the test in gcc.dg though it requires -march=nano. Do you want
> me to create an extra machine-dependent test?
I see Jakub addressed this question (thanks!) so please incorporate his
suggestion. There's also a typo in the ChangeLog, OK with that fixed.
Alexander
> 2018-04-23 Andrey Belevantsev <abel@ispras.ru>
>
> PR rtl-optimization/85423
>
> * sel-sched-ir.c (has_dependence_note_mem_dep): Only discard
Should be "has_dependence_note_dep" (without the "mem_" ;)
Alexander
More information about the Gcc-patches
mailing list