[PATCH][i386] Adding MOVDIRI and MOVDIR64B instructions

Peryt, Sebastian sebastian.peryt@intel.com
Thu Apr 19 15:13:00 GMT 2018


> On Thu, Apr 19, 2018 at 3:11 PM, Peryt, Sebastian <sebastian.peryt@intel.com>
> wrote:
> >> On Thu, Apr 19, 2018 at 2:35 PM, Peryt, Sebastian
> >> <sebastian.peryt@intel.com>
> >> wrote:
> >> >> On Wed, Apr 18, 2018 at 2:56 PM, Peryt, Sebastian
> >> >> <sebastian.peryt@intel.com>
> >> >> wrote:
> >> >> > Hi,
> >> >> >
> >> >> > This patch enables new instructions - MOVDIRI and MOVDIR64B.
> >> >> >
> >> >> > Is it ok for trunk?
> >> >>
> >> >> Is there a reason that one flag goes to ix86_isa_flags and the
> >> >> other to ix86_isa_flags2?
> >> >
> >> > This is because of usage of OPTION_MASK_ISA_MOVDIRI |
> >> > OPTION_MASK_ISA_64BIT which would end up in different isa flags
> >> > tables. And MOVDIR64B doesn't use this option, so it can be in
> ix86_isa_flags2.
> >>
> >> Ah, indeed.
> >>
> >> The patch is OK for mainline then.
> >
> > Thanks!
> >
> >>
> >> (Please note that until gcc-8 is branched, patches that add new
> >> features won't be approved as we are nearing the release.)
> >
> > Can you please explain what this actually mean? I got confused. Also
> > I'd like to mention that I have few more patches I'm going to send soon.
> >
> > That this mean I can merge this one in trunk, but there is no guarantee it will
> be added into GCC-8?
> 
> No, the patch will be included in gcc-8, as gcc-8 has not yet branched from the
> trunk. But since branch date is approaching, we don't want to destabilize trunk
> by accepting patches that introduce new features, so they will have to be
> postponed and committed to the trunk after gcc-8 is branched.
> 
> Uros.

Ok, thank you. That explains it now.

Sebastian


More information about the Gcc-patches mailing list