[patch, fortran] Remove parallell annotation from DO CONCURRENT

Thomas Koenig tkoenig@netcologne.de
Wed Apr 11 19:47:00 GMT 2018


Am 11.04.2018 um 20:33 schrieb Jakub Jelinek:

>> I have attached updated patch which moves the test case to
>> gfortran.dg/gomp (where it actually passes).
> 
> How could it pass there?  dg-do run tests don't belong into g*.dg/gomp/,
> nothing adds the -B etc. options needed to find libgomp.spec or libgomp
> as a library, or adds it to LD_LIBRARY_PATH etc.
> There are zero dg-do run tests in gfortran.dg/gomp/, there are 4
> dg-do run tests in c-c++-common/gomp/, but those work fine because they
> use -fopenmp-simd option rather than
> -fopenmp/-fopenacc/-ftree-parallelize-loops= etc.

So, where should the test go?

The suggestion in PR 85346, to put it into
libgomp/testsuite/libgomp.fortran/, does not work:

Running ../../../../trunk/libgomp/testsuite/libgomp.fortran/fortran.exp ...
FAIL: libgomp.fortran/do_concurrent_5.f90   -O  execution test

even when ne (the array size) has been reduced to 2**20, far below
reasonable memory limits.  The test passes when given the
-O1 -ftree-parallelize-loops=2 options by hand.

So, what's the idea? Is there actually a directory which works,
or are we left with a wrong-code bug for which no test case is
possible? That would be quite bad, I think.

	Thomas



More information about the Gcc-patches mailing list