[PATCH, testsuite, 2/2] Add scan-ltrans-tree-dump
Tom de Vries
Tom_deVries@mentor.com
Wed Apr 4 08:59:00 GMT 2018
On 04/03/2018 07:49 PM, Bernhard Reutner-Fischer wrote:
>> This patch adds scan-ltrans-tree-dump.
>
> Please check all error calls to talk about the correct function -- at least scan-ltrans-tree-dump-times is wrong.
>
Hi,
thanks for noticing that. I'll update the patches to fix that.
But I wonder if it's not a better idea to get the function name using
"info level", and to move the code that checks the number of arguments
into a utility function, as done in the demonstrator patch below.
Rainer, Mike, any comments? I can write a patch that uses check_num_args
in testsuite/lib/*.exp (though I'm not yet sure where to move it such
that it can be used everywhere).
Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.patch
Type: text/x-patch
Size: 1401 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180404/1f7a0777/attachment.bin>
More information about the Gcc-patches
mailing list