[PATCH] streambuf_iterator: avoid debug-dependent behaviour

Jonathan Wakely jwakely@redhat.com
Thu Sep 28 10:58:00 GMT 2017


On 28/09/17 11:50 +0100, Jonathan Wakely wrote:
>On 21/09/17 07:46 +0200, François Dumont wrote:
>>Gentle reminder, ok to commit ?
>
>No. Could you and Petr please come to an agreement about what is
>actually wrong with the current implementation, and agree on a
>solution?
>
>Currently you're both just proposing patches that do different things,
>without indicating why one patch is better than the other.
>
>I understand that we want to remove the debugmode-dependent behaviour,
>but I'd like to see any other changes justified by references to the
>standard.

Here's a test we currently fail, but it looks like we should pass it:
http://llvm.org/svn/llvm-project/libcxx/trunk/test/std/iterators/stream.iterators/istreambuf.iterator/istreambuf.iterator.cons/proxy.pass.cpp

Do the changes either of you is proposing change this result?




More information about the Gcc-patches mailing list