[PR middle-end/82319] Fix ICE in pattern

[Andrew Pinski]

On Wed, Sep 27, 2017 at 12:56 AM, Richard Biener <rguenther@suse.de> wrote:
> On Tue, 26 Sep 2017, Andrew Pinski wrote:
>
>> On Tue, Sep 26, 2017 at 10:56 PM, Yuri Gribov <tetra2005@gmail.com> wrote:
>> > Hi all,
>> >
>> > This patch fixes a trivial ICE in recent pattern.  Bootstrapped and
>> > regtested on x86_64.
>> >
>> > Ok to commit?
>
> Ok.
>
>> >+ bool cst_int_p = ! real_isnan (cst) && real_identical (&icst, cst);
>>
>> The GCC coding style says no space between the ! and the expression.
>
> Does it?  I thought it says the opposite.

Yes, see https://gcc.gnu.org/codingconventions.html#Expressions .

For                               Use......instead of
logical not                     !x           ! x
bitwise complement      ~x         ~ x
unary minus                  -x          - x
cast                               (foo) x   (foo)x
pointer dereference      *x           * x


Thanks,
Andrew

>
> Richard.
>
>> Note for clarity I would put () around !real_isnan (cst) though.
>> Other than that I don't see anything wrong with the patch (I cannot
>> approve the patch though).
>>
>> Thanks,
>> Andrew
>>
>> >
>> > -Y
>>
>>
>
> --
> Richard Biener <rguenther@suse.de>
> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)