[PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

Kyrill Tkachov kyrylo.tkachov@foss.arm.com
Fri Sep 15 16:57:00 GMT 2017


On 15/09/17 16:38, Charles Baylis wrote:
> On 13 September 2017 at 10:02, Kyrill  Tkachov
> <kyrylo.tkachov@foss.arm.com> wrote:
>
>> Please add a comment here saying that the units are in COSTS_N_INSNS
>> so that we can reduce the temptation to use these in inappropriate contexts.
>>> +      if (VECTOR_MODE_P (mode))
>>> +       {
>>> +         *cost += current_tune->addr_mode_costs->vector[op_type];
>>> +       }
>>> +      else if (FLOAT_MODE_P (mode))
>>> +       {
>>> +         *cost += current_tune->addr_mode_costs->fp[op_type];
>>> +       }
>>> +      else
>>> +       {
>>> +         *cost += current_tune->addr_mode_costs->integer[op_type];
>>> +       }
>>
>> No need for brackets for single-statement conditionals.
> Done.

Thanks, this is ok once the prerequisites are sorted.

Kyrill



More information about the Gcc-patches mailing list