[PATCH v2, rs6000] Fix PR81833

Segher Boessenkool segher@kernel.crashing.org
Tue Sep 5 17:04:00 GMT 2017


Hi!

On Tue, Aug 29, 2017 at 04:47:18PM -0500, Bill Schmidt wrote:
> Thanks for approving the previous patch with changes.  I've made those and also
> modified the test case to require VSX hardware for execution.  I duplicated the
> test so we get coverage on P7 BE 32/64 and P8 BE/LE.  I'd appreciate it if you
> could look over the dejagnu instructions once more on these.  Thanks!

> --- gcc/testsuite/gcc.target/powerpc/pr81833-1.c	(nonexistent)
> +++ gcc/testsuite/gcc.target/powerpc/pr81833-1.c	(working copy)
> @@ -0,0 +1,59 @@
> +/* PR81833: This used to fail due to improper implementation of vec_msum.  */
> +/* Test case relies on -mcpu=power7 or later.  Currently we don't have
> +   machinery to express that, so we have two separate tests for -mcpu=power7
> +   and -mcpu=power8 to catch 32-bit BE on P7 and 64-bit BE/LE on P8.  */
> +
> +/* { dg-do run } */
> +/* { dg-require-effective-target vsx_hw } */
> +/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
> +/* { dg-options "-mcpu=power8 -O2" } */

As I explained off-list, but here's for the record:

Since this is a run test and you use -mcpu=power8, you probably should
use p8vector_hw instead of vsx_hw.

Okay with that.  Thanks!


Segher



More information about the Gcc-patches mailing list