[PATCH][GCC][ARM][AArch64] Testsuite framework changes and execution tests [Patch (8/8)]

[Kyrill Tkachov]

Hi Tamar,

On 06/10/17 13:45, Tamar Christina wrote:
> Hi All,
>
> this is a minor respin of the patch with the comments addressed. Note 
> this patch is now 7/8 in the series.
>
>
> Regtested on arm-none-eabi, armeb-none-eabi,
> aarch64-none-elf and aarch64_be-none-elf with no issues found.
>
> Ok for trunk?
>
> gcc/testsuite
> 2017-10-06  Tamar Christina  <tamar.christina@arm.com>
>
>         * lib/target-supports.exp
> (check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache): New.
>         (check_effective_target_arm_v8_2a_dotprod_neon_ok): New.
>         (add_options_for_arm_v8_2a_dotprod_neon): New.
>         (check_effective_target_arm_v8_2a_dotprod_neon_hw): New.
>         (check_effective_target_vect_sdot_qi): New.
>         (check_effective_target_vect_udot_qi): New.
>         * gcc.target/arm/simd/vdot-exec.c: New.
>         * gcc.target/aarch64/advsimd-intrinsics/vdot-exec.c: New.
>         * gcc/doc/sourcebuild.texi: Document arm_v8_2a_dotprod_neon.
> ________________________________________
> From: Tamar Christina
> Sent: Monday, September 4, 2017 2:01:40 PM
> To: Christophe Lyon
> Cc: gcc-patches@gcc.gnu.org; nd; James Greenhalgh; Richard Earnshaw; 
> Marcus Shawcroft
> Subject: RE: [PATCH][GCC][ARM][AArch64] Testsuite framework changes 
> and execution tests [Patch (8/8)]
>
> Hi Christophe,
>
> > >
> > > gcc/testsuite
> > > 2017-09-01  Tamar Christina <tamar.christina@arm.com>
> > >
> > >         * lib/target-supports.exp
> > > (check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache):
> > New.
> > > (check_effective_target_arm_v8_2a_dotprod_neon_ok): New.
> > >         (add_options_for_arm_v8_2a_dotprod_neon): New.
> > > (check_effective_target_arm_v8_2a_dotprod_neon_hw): New.
> > >         (check_effective_target_vect_sdot_qi): New.
> > >         (check_effective_target_vect_udot_qi): New.
> > >         * gcc.target/arm/simd/vdot-exec.c: New.
> >
> > Aren't you defining twice P() and ARR() in vdot-exec.c ?
> > I'd expect a preprocessor error, did I read too quickly?
> >
>
> Yes they are defined twice but they're not redefined, all the definitions
> are exactly the same so the pre-processor doesn't care. I can leave only
> one if this is confusing.
>
> >
> > Thanks,
> >
> > Christophe
> >
> > >         * gcc.target/aarch64/advsimd-intrinsics/vdot-exec.c: New.
> > >         * gcc/doc/sourcebuild.texi: Document arm_v8_2a_dotprod_neon.
> > >
> > > --
This looks ok to me.

Thanks,
Kyrill