[PATCH][AArch64] Fix ICE caused in aarch64_simd_valid_immediate

[Tamar Christina]

Hi Sudi,

Committed as r253490 on your behalf.

Thanks,
Tamar
________________________________________
From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org> on behalf of Sudi Das <Sudi.Das@arm.com>
Sent: Friday, October 6, 2017 2:19:46 PM
To: Richard Earnshaw; Jakub Jelinek
Cc: gcc-patches@gcc.gnu.org; nd; sellcey@cavium.com; Marcus Shawcroft; James Greenhalgh
Subject: Re: [PATCH][AArch64] Fix ICE caused in aarch64_simd_valid_immediate

Hi Richard

*** gcc/ChangeLog ***

2017-10-05  Sudakshina Das  <sudi.das@arm.com>

        PR target/82440
        * config/aarch64/predicates.md (aarch64_reg_or_orr_imm): Only call
        aarch64_simd_valid_immediate on CONST_VECTORs.
        (aarch64_reg_or_bic_imm): Likewise.

*** gcc/testsuite/ChangeLog ***

2017-10-05  Sudakshina Das  <sudi.das@arm.com>

        * gcc.target/aarch64/bic_imm_1.c: New test.
        * gcc.target/aarch64/orr_imm_1.c: Likewise.


Also can someone please apply it for me. I do not have commit access.

Thanks
Sudi


From: Richard Earnshaw (lists) <Richard.Earnshaw@arm.com>
Sent: Friday, October 6, 2017 2:01 PM
To: Sudi Das; Jakub Jelinek
Cc: gcc-patches@gcc.gnu.org; nd; sellcey@cavium.com; Marcus Shawcroft; James Greenhalgh
Subject: Re: [PATCH][AArch64] Fix ICE caused in aarch64_simd_valid_immediate

On 06/10/17 12:01, Sudi Das wrote:
>
> Hi Jakub
>
> I have modified the entries:
>
> *** gcc/ChangeLog ***
>
> 2017-10-05  Sudakshina Das  <sudi.das@arm.com>
>
>         PR target/82440
>        * config/aarch64/predicates.md (aarch64_reg_or_orr_imm): Changed to
>        to only call aarch64_simd_valid_immediate on CONST_VECTORs.

You don't need to say 'Changed to' (or even 'Changed to to' :-).  Simply
say  'Only call ...'.

>        (aarch64_reg_or_bic_imm): Likewise.
>
> *** gcc/testsuite/ChangeLog ***
>
> 2017-10-05  Sudakshina Das  <sudi.das@arm.com>
>
>        * gcc.target/aarch64/bic_imm_1.c: New test.
>        * gcc.target/aarch64/orr_imm_1.c: Likewise..

too many full stops.

OK with those nits fixed.

R.

>
>
> Thanks
> Sudi
>
>
> From: Jakub Jelinek <jakub@redhat.com>
> Sent: Friday, October 6, 2017 11:11 AM
> To: Sudi Das
> Cc: gcc-patches@gcc.gnu.org; nd; sellcey@cavium.com; Marcus Shawcroft; Richard Earnshaw; James Greenhalgh
> Subject: Re: [PATCH][AArch64] Fix ICE caused in aarch64_simd_valid_immediate
>    
> On Fri, Oct 06, 2017 at 09:52:35AM +0000, Sudi Das wrote:
>> This patch is a fix for PR 82440.
>> The predicates aarch64_reg_or_bic_imm and aarch64_reg_or_orr_imm missed out on
>> checking for a CONST_VECTOR before calling aarch64_simd_valid_immediate function.
>> Also I think James forgot to add the test cases in the original patch submitted.
>>
>> Testing done : Checked for regressions on bootstrapped aarch64-none-linux-gnu.
>> Ok for trunk?
>>
>> Thanks
>> Sudi
>>
>> The ChangeLog entry is as follows:
>>
>> *** gcc/ChangeLog ***
>>
>> 2017-10-06  Sudakshina Das  <sudi.das@arm.com>
>>
>>         PR target/82440
>>         * config/aarch64/predicates.md (aarch64_reg_or_orr_imm): Modified.
>>         (aarch64_reg_or_bic_imm): Likewise.
>
> I'll defer the actual review to aarch64 maintainers, just want to say that
> this is not a correct ChangeLog entry.  You should say what has changed, not
> just that something has changed.  Something like
> Only call aarch64_simd_valid_immediate on CONST_VECTORs.
> or similar.
>
>         Jakub
>    
>