[PATCH] Fix recent tree-ssa-dse.c regressions (PR tree-optimization/8238[789])

Jeff Law law@redhat.com
Mon Oct 2 15:39:00 GMT 2017


On 10/02/2017 07:51 AM, Jakub Jelinek wrote:
> Hi!
> 
> live_bytes is non-NULL always, m_live_bytes is auto_sbitmap that is
> constructed in dse_dom_walker ctor:
>   dse_dom_walker (cdi_direction direction)
>     : dom_walker (direction),
>     m_live_bytes (PARAM_VALUE (PARAM_DSE_MAX_OBJECT_SIZE)),
>     m_byte_tracking_enabled (false) {}
> Whether live_bytes tracks anything right now or not is determined by
> byte_tracking_enabled flag.
> 
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
> 
> 2017-10-02  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR tree-optimization/82387
> 	PR tree-optimization/82388
> 	PR tree-optimization/82389
> 	* tree-ssa-dse.c (dse_classify_store): Test byte_tracking_enabled
> 	instead of live_bytes non-NULL.
> 
> 	* gcc.c-torture/compile/pr82389.c: New test.
> 	* gcc.c-torture/execute/pr82387.c: New test.
> 	* gcc.c-torture/execute/pr82388.c: New test.
OK.  Sorry for the breakage.  I wonder how that slipped through given
how badly it appears to be broken.

Anyway, thank for cleaning up my mess.

jeff



More information about the Gcc-patches mailing list