[PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

David Malcolm dmalcolm@redhat.com
Mon Nov 27 22:34:00 GMT 2017


On Mon, 2017-11-27 at 09:40 +0100, Olivier Hainque wrote:
> (typo in David's email address in the previous message,
> resending. sorry for the duplicates)
> 
> Hi Jeff,
> 
> (Thanks for your feedback)
> 
> > On Nov 27, 2017, at 04:55 , Jeff Law <law@redhat.com> wrote:
> > 
> > > 	* Makefile.in (SELFTEST_FLAGS): Use nul instead of /dev/null
> > > 	on mingw build hosts.
> > 
> > Would it make more sense to set the output file to HOST_BIT_BUCKET
> > when
> > -fselftest is active?
> 
> 
> Hmm, possibly. Interesting suggestion :)
> 
> David, who introduced the framework, would
> know for sure - cc'ed.
> 
> David, thoughts on this ?
 
[CCing Tamar]

The selftests currently assume both:
(a) reading a source file from /dev/null, and
(b) writing the generated asm to /dev/null

I note that r241895 added "-o /dev/null" for the asm output to "Fix the
Windows native x86-64 build.":

+2016-11-07  Tamar Christina  <tamar.christina@arm.com>
+
+       PR driver/78196
+       * Makefile.in (SELFTEST_FLAGS): Added -o /dev/null.
+

HOST_BIT_BUCKET seems to be a header thing, rather than a Makefile
thing; presumably there would need to be logic to handle both input and
output for the HOST_BIT_BUCKET approach.

Given that, I prefer Olivier's patch - it seems simpler to me.

Dave



More information about the Gcc-patches mailing list