[PATCH] ARM testsuite: force hardfp for addr-modes-float.c

Charles Baylis charles.baylis@linaro.org
Mon Nov 27 19:26:00 GMT 2017


On 27 November 2017 at 17:47, Kyrill  Tkachov
<kyrylo.tkachov@foss.arm.com> wrote:
> Hi Charles,
>
> On 27/11/17 17:03, Charles Baylis wrote:
>>
>> Some of the new tests in addr-modes-float.c, which were introduced for
>> the rework of addressing modes costs [1] fail when GCC is configured
>> to default to a softfp calling convention. Fix this by annotating the
>> test functions with __attribute__((pcs("aapcs-vfp"))).
>
>
> The usual approach to this problem is to add an -mfloat-abi=hard to the
> dg-options
> of the test (the tests are not dg-run, so there's no link-time mismatch
> concerns).
> Any particular reason to use the pcs attribute instead?

With the way I have GCC configured, it doesn't work to do this when
including certain system headers, such as arm_neon.h.

In file included from
/home/cbaylis/tools/sysroot-arm-unknown-linux-gnueabi-git/usr/include/features.h:447,
                 from
/home/cbaylis/tools/sysroot-arm-unknown-linux-gnueabi-git/usr/include/bits/libc-header-start.h:33,
                 from
/home/cbaylis/tools/sysroot-arm-unknown-linux-gnueabi-git/usr/include/stdint.h:26,
                 from /home/cbaylis/buildarea/gcc/build2/gcc/include/stdint.h:9,
                 from
/home/cbaylis/buildarea/gcc/build2/gcc/include/arm_fp16.h:34,
                 from
/home/cbaylis/buildarea/gcc/build2/gcc/include/arm_neon.h:41,
                 from
/home/cbaylis/srcarea/gcc/gcc-git/gcc/testsuite/gcc.target/arm/addr-modes-float.c:6:
/home/cbaylis/tools/sysroot-arm-unknown-linux-gnueabi-git/usr/include/gnu/stubs.h:10:11:
fatal error: gnu/stubs-hard.h: No such file or directory
compilation terminated.



More information about the Gcc-patches mailing list