[PATCH] Missing noexcept in string_view::find_first_of declaration

Jonathan Wakely jwakely@redhat.com
Fri Nov 24 19:03:00 GMT 2017


On 24/11/17 18:09 +0100, Stephan Bergmann wrote:
>cf. definition in libstdc++-v3/include/bits/string_view.tcc that does have the
>noexcept (like all the other overloads defined inline in
>libstdc++-v3/include/std/string_view do).

I thought Jason already fixed this in
https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01106.html but it
doesn't seem to have been committed yet.

I'll take care of it. Thanks for the patch.


>---
> libstdc++-v3/include/std/string_view | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libstdc++-v3/include/std/string_view b/libstdc++-v3/include/std/string_view
>index fa834002726..68b4b08f8f4 100644
>--- a/libstdc++-v3/include/std/string_view
>+++ b/libstdc++-v3/include/std/string_view
>@@ -323,7 +323,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>       { return this->find(__c, __pos); }
> 
>       constexpr size_type
>-      find_first_of(const _CharT* __str, size_type __pos, size_type __n) const;
>+      find_first_of(const _CharT* __str, size_type __pos, size_type __n) const noexcept;
> 
>       constexpr size_type
>       find_first_of(const _CharT* __str, size_type __pos = 0) const noexcept
>-- 
>2.13.6
>



More information about the Gcc-patches mailing list