[PATCH 1/7] [libsanitizer, committed] Remove semicolon after do {} while (0) in macro body

Tom de Vries Tom_deVries@mentor.com
Wed Nov 8 13:46:00 GMT 2017


On 11/08/2017 09:16 AM, Jakub Jelinek wrote:
> On Sun, Nov 05, 2017 at 11:02:32AM +0100, Tom de Vries wrote:
>> this removes a semicolon after "do {} while (0)" in several macro bodies in
>> libsanitizer. This allows the macros to be used in if-then-elses without
>> curly braces.
>>
>> Committed as obvious.
> 
> This is wrong, these files are copied directly from upstream, so if you
> want those changes, you'd need to submit it into the LLVM phabricator,
> get it approved there.  Otherwise these changes will go away next time
> merge from upstream is performed.

Thanks for pointing this out.

Filed:
- https://reviews.llvm.org/D39793
   "[asan] Remove semicolon after do {} while (0)"
- https://reviews.llvm.org/D39794
   "[lsan] Remove semicolon after do {} while (0)"

Thanks,
- Tom



More information about the Gcc-patches mailing list