[PATCH] Fix test-suite fallout of default -Wreturn-type.

Paolo Carlini paolo.carlini@oracle.com
Mon Nov 6 12:20:00 GMT 2017


Hi again,

On 06/11/2017 12:40, Paolo Carlini wrote:
> Hi,
>
> On 06/11/2017 11:41, Martin Liška wrote:
>> Sorry for that. It's related to x86 target specific test-cases. I'll 
>> prepare patch as soon as possible. 
> Ok, thanks.
>
> Note, I'm seeing a few - expected, give the enabled warning - fails in 
> the libstdc++-v3 testsuite too. Eg:
>
> FAIL: 20_util/optional/cons/deduction.cc (test for excess errors)
> FAIL: 20_util/pair/cons/deduction.cc (test for excess errors)
> FAIL: 20_util/pair/traits.cc (test for excess errors)
> FAIL: 20_util/tuple/cons/deduction.cc (test for excess errors)
For the library I'm finishing testing the below.

Paolo.

////////////////////
-------------- next part --------------
2017-11-06  Paolo Carlini  <paolo.carlini@oracle.com>

	* testsuite/20_util/optional/cons/deduction.cc: Avoid -Wreturn-type
	warnings.
	* testsuite/20_util/pair/cons/deduction.cc: Likewise.
	* testsuite/20_util/pair/traits.cc: Likewise.
	* testsuite/20_util/tuple/cons/deduction.cc: Likewise.
	* testsuite/20_util/variant/compile.cc: Likewise.
	* testsuite/23_containers/map/modifiers/try_emplace/1.cc: Likewise.
	* testsuite/23_containers/unordered_map/modifiers/try_emplace.cc:
	Likewise.

-------------- next part --------------
Index: testsuite/20_util/optional/cons/deduction.cc
===================================================================
--- testsuite/20_util/optional/cons/deduction.cc	(revision 254449)
+++ testsuite/20_util/optional/cons/deduction.cc	(working copy)
@@ -24,8 +24,8 @@
 struct MoveOnly
 {
   MoveOnly() = default;
-  MoveOnly(MoveOnly&&) {}
-  MoveOnly& operator=(MoveOnly&&) {}
+  MoveOnly(MoveOnly&&);
+  MoveOnly& operator=(MoveOnly&&);
 };
 
 int main()
Index: testsuite/20_util/pair/cons/deduction.cc
===================================================================
--- testsuite/20_util/pair/cons/deduction.cc	(revision 254449)
+++ testsuite/20_util/pair/cons/deduction.cc	(working copy)
@@ -30,8 +30,8 @@
 struct MoveOnly
 {
   MoveOnly() = default;
-  MoveOnly(MoveOnly&&) {}
-  MoveOnly& operator=(MoveOnly&&) {}
+  MoveOnly(MoveOnly&&);
+  MoveOnly& operator=(MoveOnly&&);
 };
 
 void
Index: testsuite/20_util/pair/traits.cc
===================================================================
--- testsuite/20_util/pair/traits.cc	(revision 254449)
+++ testsuite/20_util/pair/traits.cc	(working copy)
@@ -31,8 +31,8 @@
 
 struct ThrowingCopy
 {
-  ThrowingCopy(const ThrowingCopy&) {}
-  ThrowingCopy& operator=(const ThrowingCopy&) {}
+  ThrowingCopy(const ThrowingCopy&);
+  ThrowingCopy& operator=(const ThrowingCopy&);
 };
 
 int main()
Index: testsuite/20_util/tuple/cons/deduction.cc
===================================================================
--- testsuite/20_util/tuple/cons/deduction.cc	(revision 254442)
+++ testsuite/20_util/tuple/cons/deduction.cc	(working copy)
@@ -30,8 +30,8 @@
 struct MoveOnly
 {
   MoveOnly() = default;
-  MoveOnly(MoveOnly&&) {}
-  MoveOnly& operator=(MoveOnly&&) {}
+  MoveOnly(MoveOnly&&);
+  MoveOnly& operator=(MoveOnly&&);
 };
 
 void
Index: testsuite/20_util/variant/compile.cc
===================================================================
--- testsuite/20_util/variant/compile.cc	(revision 254442)
+++ testsuite/20_util/variant/compile.cc	(working copy)
@@ -481,37 +481,37 @@
     static_assert(MA_VAL == is_trivially_move_assignable_v<variant<A>>, ""); \
   }
   TEST_TEMPLATE(=default, =default, =default, =default, =default,  true,  true,  true,  true)
-  TEST_TEMPLATE(=default, =default, =default, =default,       {},  true,  true,  true, false)
-  TEST_TEMPLATE(=default, =default, =default,       {}, =default,  true,  true, false,  true)
-  TEST_TEMPLATE(=default, =default, =default,       {},       {},  true,  true, false, false)
-  TEST_TEMPLATE(=default, =default,       {}, =default, =default,  true, false,  true,  true)
-  TEST_TEMPLATE(=default, =default,       {}, =default,       {},  true, false,  true, false)
-  TEST_TEMPLATE(=default, =default,       {},       {}, =default,  true, false, false,  true)
-  TEST_TEMPLATE(=default, =default,       {},       {},       {},  true, false, false, false)
-  TEST_TEMPLATE(=default,       {}, =default, =default, =default, false,  true,  true,  true)
-  TEST_TEMPLATE(=default,       {}, =default, =default,       {}, false,  true,  true, false)
-  TEST_TEMPLATE(=default,       {}, =default,       {}, =default, false,  true, false,  true)
-  TEST_TEMPLATE(=default,       {}, =default,       {},       {}, false,  true, false, false)
-  TEST_TEMPLATE(=default,       {},       {}, =default, =default, false, false,  true,  true)
-  TEST_TEMPLATE(=default,       {},       {}, =default,       {}, false, false,  true, false)
-  TEST_TEMPLATE(=default,       {},       {},       {}, =default, false, false, false,  true)
-  TEST_TEMPLATE(=default,       {},       {},       {},       {}, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default, =default, =default, =default, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default, =default, =default,       {}, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default, =default,       {}, =default, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default, =default,       {},       {}, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default,       {}, =default, =default, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default,       {}, =default,       {}, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default,       {},       {}, =default, false, false, false, false)
-  TEST_TEMPLATE(      {}, =default,       {},       {},       {}, false, false, false, false)
-  TEST_TEMPLATE(      {},       {}, =default, =default, =default, false, false, false, false)
-  TEST_TEMPLATE(      {},       {}, =default, =default,       {}, false, false, false, false)
-  TEST_TEMPLATE(      {},       {}, =default,       {}, =default, false, false, false, false)
-  TEST_TEMPLATE(      {},       {}, =default,       {},       {}, false, false, false, false)
-  TEST_TEMPLATE(      {},       {},       {}, =default, =default, false, false, false, false)
-  TEST_TEMPLATE(      {},       {},       {}, =default,       {}, false, false, false, false)
-  TEST_TEMPLATE(      {},       {},       {},       {}, =default, false, false, false, false)
-  TEST_TEMPLATE(      {},       {},       {},       {},       {}, false, false, false, false)
+  TEST_TEMPLATE(=default, =default, =default, =default,         ,  true,  true,  true, false)
+  TEST_TEMPLATE(=default, =default, =default,         , =default,  true,  true, false,  true)
+  TEST_TEMPLATE(=default, =default, =default,         ,         ,  true,  true, false, false)
+  TEST_TEMPLATE(=default, =default,         , =default, =default,  true, false,  true,  true)
+  TEST_TEMPLATE(=default, =default,         , =default,         ,  true, false,  true, false)
+  TEST_TEMPLATE(=default, =default,         ,         , =default,  true, false, false,  true)
+  TEST_TEMPLATE(=default, =default,         ,         ,         ,  true, false, false, false)
+  TEST_TEMPLATE(=default,         , =default, =default, =default, false,  true,  true,  true)
+  TEST_TEMPLATE(=default,         , =default, =default,         , false,  true,  true, false)
+  TEST_TEMPLATE(=default,         , =default,         , =default, false,  true, false,  true)
+  TEST_TEMPLATE(=default,         , =default,         ,         , false,  true, false, false)
+  TEST_TEMPLATE(=default,         ,         , =default, =default, false, false,  true,  true)
+  TEST_TEMPLATE(=default,         ,         , =default,         , false, false,  true, false)
+  TEST_TEMPLATE(=default,         ,         ,         , =default, false, false, false,  true)
+  TEST_TEMPLATE(=default,         ,         ,         ,         , false, false, false, false)
+  TEST_TEMPLATE(        , =default, =default, =default, =default, false, false, false, false)
+  TEST_TEMPLATE(        , =default, =default, =default,         , false, false, false, false)
+  TEST_TEMPLATE(        , =default, =default,         , =default, false, false, false, false)
+  TEST_TEMPLATE(        , =default, =default,         ,         , false, false, false, false)
+  TEST_TEMPLATE(        , =default,         , =default, =default, false, false, false, false)
+  TEST_TEMPLATE(        , =default,         , =default,         , false, false, false, false)
+  TEST_TEMPLATE(        , =default,         ,         , =default, false, false, false, false)
+  TEST_TEMPLATE(        , =default,         ,         ,         , false, false, false, false)
+  TEST_TEMPLATE(        ,         , =default, =default, =default, false, false, false, false)
+  TEST_TEMPLATE(        ,         , =default, =default,         , false, false, false, false)
+  TEST_TEMPLATE(        ,         , =default,         , =default, false, false, false, false)
+  TEST_TEMPLATE(        ,         , =default,         ,         , false, false, false, false)
+  TEST_TEMPLATE(        ,         ,         , =default, =default, false, false, false, false)
+  TEST_TEMPLATE(        ,         ,         , =default,         , false, false, false, false)
+  TEST_TEMPLATE(        ,         ,         ,         , =default, false, false, false, false)
+  TEST_TEMPLATE(        ,         ,         ,         ,         , false, false, false, false)
 #undef TEST_TEMPLATE
 
 #define TEST_TEMPLATE(CC, MC, CA, MA) \
@@ -529,21 +529,21 @@
     static_assert(!is_trivially_move_assignable_v<variant<AllDeleted, A>>, ""); \
   }
   TEST_TEMPLATE(=default, =default, =default, =default)
-  TEST_TEMPLATE(=default, =default, =default,       {})
-  TEST_TEMPLATE(=default, =default,       {}, =default)
-  TEST_TEMPLATE(=default, =default,       {},       {})
-  TEST_TEMPLATE(=default,       {}, =default, =default)
-  TEST_TEMPLATE(=default,       {}, =default,       {})
-  TEST_TEMPLATE(=default,       {},       {}, =default)
-  TEST_TEMPLATE(=default,       {},       {},       {})
-  TEST_TEMPLATE(      {}, =default, =default, =default)
-  TEST_TEMPLATE(      {}, =default, =default,       {})
-  TEST_TEMPLATE(      {}, =default,       {}, =default)
-  TEST_TEMPLATE(      {}, =default,       {},       {})
-  TEST_TEMPLATE(      {},       {}, =default, =default)
-  TEST_TEMPLATE(      {},       {}, =default,       {})
-  TEST_TEMPLATE(      {},       {},       {}, =default)
-  TEST_TEMPLATE(      {},       {},       {},       {})
+  TEST_TEMPLATE(=default, =default, =default,         )
+  TEST_TEMPLATE(=default, =default,         , =default)
+  TEST_TEMPLATE(=default, =default,         ,         )
+  TEST_TEMPLATE(=default,         , =default, =default)
+  TEST_TEMPLATE(=default,         , =default,         )
+  TEST_TEMPLATE(=default,         ,         , =default)
+  TEST_TEMPLATE(=default,         ,         ,         )
+  TEST_TEMPLATE(        , =default, =default, =default)
+  TEST_TEMPLATE(        , =default, =default,         )
+  TEST_TEMPLATE(        , =default,         , =default)
+  TEST_TEMPLATE(        , =default,         ,         )
+  TEST_TEMPLATE(        ,         , =default, =default)
+  TEST_TEMPLATE(        ,         , =default,         )
+  TEST_TEMPLATE(        ,         ,         , =default)
+  TEST_TEMPLATE(        ,         ,         ,         )
 #undef TEST_TEMPLATE
 
   static_assert(is_trivially_copy_constructible_v<variant<DefaultNoexcept, int, char, float, double>>, "");
Index: testsuite/23_containers/map/modifiers/try_emplace/1.cc
===================================================================
--- testsuite/23_containers/map/modifiers/try_emplace/1.cc	(revision 254442)
+++ testsuite/23_containers/map/modifiers/try_emplace/1.cc	(working copy)
@@ -39,6 +39,7 @@
   {
     val = other.val;
     other.moved_from_assign = true;
+    return *this;
   }
 };
 
Index: testsuite/23_containers/unordered_map/modifiers/try_emplace.cc
===================================================================
--- testsuite/23_containers/unordered_map/modifiers/try_emplace.cc	(revision 254442)
+++ testsuite/23_containers/unordered_map/modifiers/try_emplace.cc	(working copy)
@@ -39,6 +39,7 @@
   {
     val = other.val;
     other.moved_from_assign = true;
+    return *this;
   }
 };
 


More information about the Gcc-patches mailing list