[PATCH v2 04/N] Simplify usage of some TDF_* flags.

Richard Biener richard.guenther@gmail.com
Wed May 17 12:37:00 GMT 2017


On Tue, May 16, 2017 at 3:53 PM, Martin Liška <mliska@suse.cz> wrote:
> There's one another patch that merges some TDF_* flags that have
> very similar meaning and do not influence test-suite, because
> nobody is using them for scanning.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?

I think the patch removes too many TDF flags.  For example
-fdump-tree-xxx-address
will then print not only addresses of gimple stmts but also of each
tree operand.  The
change to dump_generic_node looks ok though.

Did you look who intoduced TDF_COMMENT?  ISTR it was for some graph
dumping stuff.

Likewise the TDF_VERBOSE use in tree-cfg.c shouldn't be replaced with
-details but
dropped if you trop the flag.

Did you look at effects in dump-files at all?

Richard.

> Martin



More information about the Gcc-patches mailing list