[PATCH, rs6000] gcc mainline, add builtin support for vec_popcnt() and vec_slo()
Segher Boessenkool
segher@kernel.crashing.org
Thu May 11 20:49:00 GMT 2017
Hi!
On Thu, May 11, 2017 at 10:56:48AM -0700, Carl E. Love wrote:
> * config/rs6000/rs6000-c: Add support for built-in functions
> vector unsigned char vec_popcnt (vector signed char)
> vector unsigned char vec_popcnt (vector unsigned char)
> vector unsigned short vec_popcnt (vector signed short)
> vector unsigned short vec_popcnt (vector unsigned short)
> vector unsigned int vec_popcnt (vector signed int)
> vector unsigned int vec_popcnt (vector unsigned int)
> vector unsigned long long vec_popcnt (vector signed long long)
> vector unsigned long long vec_popcnt (vector unsigned long long)
> vector signed long long vec_slo (vector signed long long, vector signed char);
> vector signed long long vec_slo (vector signed long long, vector unsigned char);
> vector unsigned long long vec_slo (vector unsigned long long, vector signed char);
> vector unsigned long long vec_slo (vector unsigned long long, vector unsigned char);
The last bunch of lines are too long, and have semicolons while the
earlier ones don't.
> * config/rs6000/altivec.h: Add define for vec_popcnt, vec_popcntb,
> vec_popth, vec_popcntw and vec_popcntd built-in functions.
Double space here (and more later). "vec_popth" is missing a few
letters I think?
Other than those nits, looks fine; please fix and commit. Thanks,
Segher
More information about the Gcc-patches
mailing list