OpenACC C front end maintenance: c_parser_oacc_single_int_clause (was: [OpenACC] num_gangs, num_workers and vector_length in c++)

Jakub Jelinek jakub@redhat.com
Wed May 10 16:36:00 GMT 2017


On Tue, May 09, 2017 at 11:27:14PM +0200, Thomas Schwinge wrote:
> Hi!
> 
> On Wed, 4 Nov 2015 14:10:29 -0800, Cesar Philippidis <cesar@codesourcery.com> wrote:
> > > [...]
> > 
> > Thanks. I've applied this patch to trunk.
> 
> > 	gcc/cp/
> > 	* (cp_parser_oacc_single_int_clause): New function.
> > 	(cp_parser_oacc_clause_vector_length): Delete.
> > 	(cp_parser_omp_clause_num_gangs): Delete.
> > 	(cp_parser_omp_clause_num_workers): Delete.
> > 	(cp_parser_oacc_all_clauses): Use cp_parser_oacc_single_int_clause
> > 	for num_gangs, num_workers and vector_length.
> 
> Here is a similar patch for the C front end, and it also adds test cases.
> OK for trunk?  During testing I also noticed some "strangeness" (also
> regarding some similar OpenMP clauses), which I'll file a PR for, later
> on.
> 
> commit 70baf3fc0c544fe63b9d3b3bebcca88daf7ce554
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date:   Fri May 5 16:38:52 2017 +0200
> 
>     OpenACC C front end maintenance: c_parser_oacc_single_int_clause
>     
>             gcc/c/
>             * c-parser.c (c_parser_omp_clause_num_gangs)
>             (c_parser_omp_clause_num_workers)
>             (c_parser_omp_clause_vector_length): Merge functions into...
>             (c_parser_oacc_single_int_clause): ... this new function.  Adjust
>             all users.
>             gcc/testsuite/
>             * c-c++-common/goacc/parallel-dims-1.c: New file.
>             * c-c++-common/goacc/parallel-dims-2.c: Likewise.

Ok.

	Jakub



More information about the Gcc-patches mailing list