[PATCH v2,rs6000] Add built-in function support for compare bytes instruction

Segher Boessenkool segher@kernel.crashing.org
Tue May 9 20:58:00 GMT 2017


Hi Kelvin,

On Mon, May 08, 2017 at 11:04:59AM -0600, Kelvin Nilsen wrote:
> +      /* If any supplied arguments are wider than 32 bits, resolve to
> +	 64-bit variant of built-in function.  */
> +      if ((arg1_mode == TImode) || (arg1_mode == DImode) ||
> +	  (arg2_mode == TImode) || (arg2_mode == DImode))

Use GET_MODE_PRECISION instead?  Or GET_MODE_BITSIZE, not sure which
is better here.

The rest of the patch looks fine to me.


Segher



More information about the Gcc-patches mailing list