[PATCH, rs6000] Fix PR target/80246, DFP builtins using the wrong types

Peter Bergner bergner@vnet.ibm.com
Thu Mar 30 07:33:00 GMT 2017


On 3/29/17 5:28 PM, Segher Boessenkool wrote:
> Typo ("argument").

Oops! :-)



>> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
>> +/* { dg-skip-if "" { powerpc*-*-*spe* } { "*" } { "" } } */
>> +/* { dg-require-effective-target dfp } */
> 
> You can leave off the default arguments "*" "".  Do we really need to
> explicitly skip on Darwin and SPE if there is a test for DFP anyway?

Good question.  I just cut pasted the above from another test,
but I think you are correct we don't need those.  I'll remove them.


>> +/* { dg-final { scan-assembler-not "drintn\\." } } */
>> +/* { dg-final { scan-assembler-not "drintnq\\." } } */
>> +/* { dg-final { scan-assembler-not "dctfix" } } */
>> +/* { dg-final { scan-assembler-not "dctfixq" } } */
> 
> If there is no "dctfix" there surely is no "dctfixq" either (i.e., your
> regexen aren't very tight).

Ahh, true.  I suppose I could also just look for "drintn" too,
since that would catch both drintn. and drintnq., ok with that
change?

Peter




More information about the Gcc-patches mailing list