[PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

[Moore, Catherine]

> -----Original Message-----
> From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com]
> Sent: Wednesday, March 15, 2017 11:37 AM
> To: Moore, Catherine <Catherine_Moore@mentor.com>
> Cc: Toma Tabacu <Toma.Tabacu@imgtec.com>; gcc-
> patches@gcc.gnu.org
> Subject: RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for
> MIPS.
> 
> Toma Tabacu <Toma.Tabacu@imgtec.com> writes:
> > The gcc.dg/pic-2.c and gcc.dg/pie-2.c tests are failing for MIPS targets
> > because __PIC__ is always set to 1 for MIPS.
> >
> > This patch makes the testsuite skip those two tests for all MIPS
> > targets.
> >
> > Tested with mips-mti-elf and mips-mti-linux-gnu.
> >
> > Should I have fixed this in target-supports.exp instead ?
> > I was worried that doing so would complicate the fpic and pie effective
> > target checks too much.
> 
> I think the skip is OK here. I'd like to get Catherine's opinion on
> this though too. I don't think we should change the definition of __PIC__
> for -fPIC on MIPS as multi-got solves 'most' issues. If we start trying to
> figure out what __PIC__ should mean on MIPS then we will get into a big
> mess with -mxgot as that is arguably __PIC__==2 but I expect there will
> be  several differing opinions.
> 
I think the skip is the right way to go as well.   The patch is OK with me.
Catherine