[PATCH] Microblaze: Fixes for RTL Checking

Michael Eager eager@eagerm.com
Fri Mar 10 00:49:00 GMT 2017


On 03/09/2017 03:35 PM, Segher Boessenkool wrote:
> Hi!
>
> On Thu, Mar 09, 2017 at 10:18:43AM -0800, Michael Eager wrote:
>> --- a/gcc/config/microblaze/microblaze.c
>> +++ b/gcc/config/microblaze/microblaze.c
>> @@ -3323,10 +3323,10 @@ microblaze_expand_shift (rtx operands[])
>>                || (GET_CODE (operands[1]) == SUBREG));
>>
>>     /* Shift by zero -- copy regs if necessary.  */
>> -  if ((GET_CODE (operands[2]) == CONST_INT) && (INTVAL (operands[2]) == 0))
>> +  if (CONST_INT_P (operands[2]) && (operands[2] == const0_rtx)
>
> You don't need that first test since you have the second (and the parens
> are superfluous as well).

Yes.  Fixed.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077



More information about the Gcc-patches mailing list