[PATCH,testsuite] MIPS: Fix register mode checking for n64 in pr68273.c.

Matthew Fortune Matthew.Fortune@imgtec.com
Thu Mar 2 21:30:00 GMT 2017


Toma Tabacu <Toma.Tabacu@imgtec.com> writes:
> pr68273.c currently fails when targeting MIPS64 with the n64 ABI.
> This is because it is checking for some registers in SImode, but, because of
> n64, they will actually be in DImode.
> 
> This patch restricts matching for SImode registers to ilp32 targets and adds
> matching for DImode registers for lp64 targets.
> This makes sure that the test is run on as many targets as possible, compared
> to the alternative of adding -mabi=32 to the test options.
> 
> I haven't checked to see what happens with eabi or o64, though.
> 
> Does this approach work ? Or should I just make separate tests for o32, n32 and
> n64, each one using -mabi=* as a test option to force an ABI ?

I'm happy with this approach.  As long as it works for o32/n32/n64 that is
sufficient right now.  If anyone starts to build and run the testsuite regularly
for default eabi/o64 then tests can be fixed which will involve much more than
just this one.

> Tested with mips-mti-elf.
> 
> Regards,
> Toma
> 
> gcc/testsuite/
> 
> 	* gcc.target/mips/pr68273.c (dg-final): Match SImode registers only for
> 	ilp32 targets and match DImode registers for lp64 targets.

OK, thanks.

Matthew



More information about the Gcc-patches mailing list