[PATCH][RFA] Fix -fstack-check with really big frames on aarch64

Florian Weimer fw@deneb.enyo.de
Thu Jun 22 18:23:00 GMT 2017


* Mike Stump:

> On Jun 22, 2017, at 8:32 AM, Jeff Law <law@redhat.com> wrote:
>> 
>> Sure.  I'll do something with 20031023-1.c to ensure it or an equivalent
>> is compiled with -fstack-check.  That isn't totally unexpected.   I
>> would have also been receptive to adding -fstack-check to the torture flags.
>
> Ouch.  Though stack checking might be important, the feature is very,
> very narrow, and once tested, if unlike to ever break or interact
> badly with other work.  I'd rather people default it to on, run the
> entire suite, fix all bugs (with test cases added for all the bugs),
> then turn it back off.

Are there many tests which give different results with and without
stack checking?

I expect that eventually, there will be a configure flag which
controls whether stack checking is enabled by default (similar to
PIE-by-default), and we could thus rely on tester variance to cover
the test suite with both flag states.



More information about the Gcc-patches mailing list