[PATCH,AIX] Enable libiberty to read AIX XCOFF
DJ Delorie
dj@redhat.com
Tue Jun 6 23:52:00 GMT 2017
David Edelsohn <dje.gcc@gmail.com> writes:
> This patch generally looks good to me -- it clearly is an incremental
> improvement. One of the libiberty maintainers, such as Ian, needs to
> approve the patch.
As AIX maintainer, I think you have the authority to approve patches
like this, which only affect your OS. I see no reason to reject the
patch myself, other than:
+ symtab = XNEWVEC (struct external_syment, ocr->nsyms * SYMESZ);
+ if (!simple_object_internal_read (sobj->descriptor,
There's no check to see if XNEWVEC succeeded.
Also, the use of XDELETEVEC is inconsistently protected with a "if (foo
!= NULL)" throughout, but passing NULL to XDELETEVEC (essentially,
free()) is allowed anyway, so this is only a stylistic issue, which I'm
not particularly worried about.
More information about the Gcc-patches
mailing list